Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-centered footer in Articles Dashboard #3112

Closed
mariocsee opened this issue Jun 10, 2019 · 14 comments
Closed

Non-centered footer in Articles Dashboard #3112

mariocsee opened this issue Jun 10, 2019 · 14 comments
Labels
bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.

Comments

@mariocsee
Copy link
Contributor

mariocsee commented Jun 10, 2019

Describe the bug
In dev.to/dashboard, the footer is aligned more to the right compared to the center column of articles. This happens between the widths of 950 and 1119 and it seems fine for anything wider or narrower.

To Reproduce

  1. Go to 'dev.to/dashboard'
  2. Adjust your width to between 950 and 1119
  3. Scroll down to the bottom
  4. See footer

Expected behavior
The footer should be centered in pages like /dashboard where there are no cards to the right or left of the center column.

Screenshots
Screen Shot 2019-06-10 at 16 58 08

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Chrome
  • Version: 75

Additional context
Note that the footer is used all throughout DEV and is not always center aligned depending on what page you're on.

@mariocsee mariocsee added bug always open for contribution external contributors welcome contribution is welcome! and removed triage labels Jun 10, 2019
@arku
Copy link
Contributor

arku commented Jun 11, 2019

Interesting. This is how it looks to me on Firefox (I am on a Mac).

image

@mariocsee
Copy link
Contributor Author

@arku Just to check, did you get to adjust your width to between 950 and 1119?

@NedyUdombat
Copy link

Hi, I would like to work on this. But I am having troubles setting up the ruby application on my local machine, any form of assistance will he highly appreciated

@arku
Copy link
Contributor

arku commented Jun 13, 2019

@mariocsee

Just to check, did you get to adjust your width to between 950 and 1119?

Ah, no I didn't. Thanks for adding the resizing step to the Reproduction steps.

I am able to reproduce the issue.

image

@arku
Copy link
Contributor

arku commented Jun 13, 2019

@NedyUdombat Thanks for offering to help! It would be helpful if you could let us know what issue you're running into.

@NedyUdombat
Copy link

@arku I am trying to setup the database and it is showing me this. If you can help I would appreciate
Screenshot 2019-06-14 at 12 53 58 AM

@rhymes
Copy link
Contributor

rhymes commented Jun 14, 2019

@NedyUdombat what happens if you issue createdb TestABC from the command line? I think it's telling you there's a password required for your installation of PostgreSQL.

You can check the DEV installation docs to see how to provide the password to the Rails application https://docs.dev.to/installation/postgresql/#configuration

@jessleenyc jessleenyc added good first issue good first issues for anyone new to programming and new to the project. tech: html/css labels Aug 8, 2019
@ganonbit
Copy link
Contributor

Ah yep, just replicated it. Looks like @media tags fighting. There's a very unneeded margin-left: 310px; in there for the @media tag for @media screen and (max-width: 1119px) and (min-width: 950px) footer .container.centered-footer { I'll try to give my shot at tackling it in a bit.

@jacobherrington
Copy link
Contributor

I believe #3965 resolved this -- is anyone still able to replicate this issue in production or with the current master branch?

@akshayymahajan
Copy link
Contributor

akshayymahajan commented Oct 4, 2019

Still able to replicate the issue..

image

@akshayymahajan
Copy link
Contributor

Is anyone still working on this? If not, I would like to tackle this..

@rhymes
Copy link
Contributor

rhymes commented Oct 7, 2019

@akshayymahajan I believe #4153 contains the fix, correct? See this comment #3112 (comment)

@akshayymahajan
Copy link
Contributor

@rhymes Yes. My bad, I thought #4153 was merged. It should fix the issue..

@maestromac
Copy link
Member

Resolved with #4153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

No branches or pull requests

9 participants