Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading list: add pagination or infinite scroll #3122

Closed
rhymes opened this issue Jun 11, 2019 · 7 comments
Closed

Reading list: add pagination or infinite scroll #3122

rhymes opened this issue Jun 11, 2019 · 7 comments
Labels
external contributors welcome contribution is welcome!

Comments

@rhymes
Copy link
Contributor

rhymes commented Jun 11, 2019

Is your feature request related to a problem? Please describe.

Right now the reading list only displays the latest 64 items. If a user has more they can't access the other items until they've unsaved or archived "N - 64" articles.

See https://github.com/thepracticaldev/dev.to/blob/master/app/javascript/readingList/readingList.jsx#L24

Describe the solution you'd like

Either have a "Load more" button like listings have to load other items, or have infinite scrolling based pagination

@jessleenyc
Copy link
Contributor

Notes from tech meeting:

  • A 'load more' button will be easier than pagination int his context because the way we navigate within pages makes it complicated to reset listeners.

@bellsenawat
Copy link
Contributor

bellsenawat commented Jun 14, 2019

@jessleenyc
Can I work on this by create load more button to solve this :)

@rhymes
Copy link
Contributor Author

rhymes commented Jun 14, 2019

Hi @bellsenawat it's all yours, thank you! Please provide screenshots along with the code

@bellsenawat
Copy link
Contributor

I have a question
"Load More" button should apply to only Reading list or including Archive page
@rhymes

@rhymes
Copy link
Contributor Author

rhymes commented Jun 18, 2019

@bellsenawat it should actually apply to any view, tags filters included

@bolariin
Copy link
Contributor

I think this issue has been resolved

@rhymes
Copy link
Contributor Author

rhymes commented Jun 25, 2019

Closed by #3221

@rhymes rhymes closed this as completed Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

4 participants