Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading list: add number of items in the header #3124

Closed
rhymes opened this issue Jun 11, 2019 · 4 comments · Fixed by #3162
Closed

Reading list: add number of items in the header #3124

rhymes opened this issue Jun 11, 2019 · 4 comments · Fixed by #3162
Labels
external contributors welcome contribution is welcome!

Comments

@rhymes
Copy link
Contributor

rhymes commented Jun 11, 2019

Is your feature request related to a problem? Please describe.

From the homepage it is possible to see how many items there are in the reading list.
Once inside https://dev.to/readinglist that information is not accessible

Describe the solution you'd like

Add the number of articles in the title.

From the current

Screenshot_2019-06-11 Reading List - The DEV Community

to something like

Screenshot_2019-06-11 Reading List - The DEV Community copy

Additional context

This number has to update anytime an item is removed or archived I guess

@andrewrod33
Copy link

Currently, the home page shows the total amount of all articles (including Archived). Would this show that number or only the non-archived count?

@rhymes
Copy link
Contributor Author

rhymes commented Jun 11, 2019

@andrewrod33 good point, I think it should list the number of non archived, and then in the https://dev.to/readinglist/archive page it should show the number of archived posts

@bolariin
Copy link
Contributor

if there are no items in the reading list would the count be absent or zero?

@rhymes
Copy link
Contributor Author

rhymes commented Jun 14, 2019

@bolariin good question. I'd replicate the logic for the reading list count of the homepage:

https://github.com/thepracticaldev/dev.to/blob/7f2045b25004e771e26112e9b3d08992b3af3245/app/assets/javascripts/initializers/initializeReadingListIcons.js#L32-L43

which seems to be: (empty) or (15) for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contributors welcome contribution is welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants