Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to a specific gist version in dev.to #3267

Closed
suntong opened this issue Jun 22, 2019 · 2 comments · Fixed by #3310
Closed

Link to a specific gist version in dev.to #3267

suntong opened this issue Jun 22, 2019 · 2 comments · Fixed by #3310
Labels
external contributors welcome contribution is welcome!

Comments

@suntong
Copy link

suntong commented Jun 22, 2019

Is your feature request related to a problem? Please describe.

The syntax to link to a specific gist file from dev.to is:

{% gist https://gist.github.com/CristinaSolana/1885435 file=gistfile1.md %}

but it is impossible to link to a specific gist version of that file -- I tried to replace the above url with url to that specific version, but got 500 Internal error when publishing it.

Describe the solution you'd like

Fix this line
https://github.com/thepracticaldev/dev.to/blob/master/app/liquid_tags/gist_tag.rb#L64
and allow link to a specific gist version.

@maestromac
Copy link
Member

Thank you for this issue @suntong . Just to be sure, what does the gist embed of a specific revision looks like?

@suntong
Copy link
Author

suntong commented Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contributors welcome contribution is welcome!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants