Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampersand is not escaped on Twitter share from the hamburger menu #3451

Closed
vepo opened this issue Jul 11, 2019 · 3 comments · Fixed by #3466
Closed

Ampersand is not escaped on Twitter share from the hamburger menu #3451

vepo opened this issue Jul 11, 2019 · 3 comments · Fixed by #3466
Labels
bug always open for contribution good first issue good first issues for anyone new to programming and new to the project.

Comments

@vepo
Copy link

vepo commented Jul 11, 2019

Describe the bug

Ampersand is not escaped on Twitter share

To Reproduce

  1. Open this post
  2. Select share option "..."
  3. Select Share to Twitter

It will open a tab with a tweet "101 Tips For Being A Great Programmer ( instead of "101 Tips For Being A Great Programmer (& Human)" by @EmmaWedekind #DEVcommunity https://dev.to/emmawedekind/101-tips-for-being-a-great-programmer-human-36nl.

Expected behavior
It should open a tab with a tweet "101 Tips For Being A Great Programmer (& Human)" by @EmmaWedekind #DEVcommunity https://dev.to/emmawedekind/101-tips-for-being-a-great-programmer-human-36nl.

@rhymes
Copy link
Contributor

rhymes commented Jul 11, 2019

@vepo what browser are you using? Because with Firefox 68 the share works correctly.

Screenshot_2019-07-11 Post a Tweet on Twitter

@vepo
Copy link
Author

vepo commented Jul 11, 2019

I select other way to share it. Not direct click on the Twitter icon. I was thinking if I share it through twitter or Linkedin.

Already updated the issue

@rhymes rhymes changed the title Ampersand is not escaped on Twitter share Ampersand is not escaped on Twitter share from the hamburger menu Jul 11, 2019
@rhymes rhymes added bug always open for contribution good first issue good first issues for anyone new to programming and new to the project. labels Jul 11, 2019
@rhymes
Copy link
Contributor

rhymes commented Jul 11, 2019

I see the bug, there's a difference in how the URL is composed in the Twitter button in the sidebar - https://github.com/thepracticaldev/dev.to/blob/master/app/views/articles/_actions.html.erb#L17 - and the "Share to Twitter" in the hamburger menu - https://github.com/thepracticaldev/dev.to/blob/master/app/views/articles/_actions.html.erb#L62 (the second one is the wrong one).

Great catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants