New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Return properties regarding series in GET request data #3669
Comments
|
Series names are not unique, so this would probably require params for the user and the series name. So I think something like We could expose this ID in the other APIs so that people could first query that to get an id. We could also have a |
|
Hello @benhalpern , I would like to volunteer for this one. |
|
@cyrillefr to keep things small maybe you could do it in steps, first a PR to add collection ids to articles and the ability to filter articles by those ids, then a separate PR with a controller to get the list of collections that a user has makes sense? |
|
Hello @rhymes, sorry for the delay. I will do it that way then, in two parts. |
|
@cyrillefr did you end up working on this? I'm happy to start working on this as I'd really like the API to return info about the Series. |
|
Hello @beeman , sorry for the delay. |
|
@rhymes can I try finish this one? :) |
|
@rhymes I started working on this. |
|
Thanks @matisnape, this is a bit tricky indeed. The goal here is to return the series a user has. I think we could mirror the website - eg. https://dev.to/rhymes/series - with something like As I think we made a mistake exposing |
|
@rhymes Regarding content of the endpoint response - the discussion above mentions IDs only. I suppose there should be serialized user details, like with the other endpoints? Anything else that should be included? |
|
mmm @matisnape I'm not sure we should serialize the user properties, they don't add much to the representation of the series, after all we're in a "sub directory" of Looking at the What do you think? |
|
Since this issue has gone stale I am going to close it. If anyone would like to still implement this feature let me know and we can turn this issue into a discussion |
Is your feature request related to a problem? Please describe.
When creating articles using the API, it's possible to assign the article to a series. However, when querying for articles from the API, no information regarding series is made available in either the objects returned
/api/articles/?=${queryString}or the data returned from/api/articles/${id}.Describe the solution you'd like
Ideally, a
seriesproperty would be returned along with the rest of the data for each article from either endpoint with the title or some other identifier of the series to which the article belongs.Describe alternatives you've considered
Additional context
The text was updated successfully, but these errors were encountered: