Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CodeClimate Issues #3739

Closed
benhalpern opened this issue Aug 18, 2019 · 16 comments
Closed

Refactor CodeClimate Issues #3739

benhalpern opened this issue Aug 18, 2019 · 16 comments
Labels
external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project. type: refactoring code refactors

Comments

@benhalpern
Copy link
Contributor

We have CodeClimate hooked up to our repo. It identifies code smells, which can be low-hanging fruit for improving the application.

Issues can be found here:

https://codeclimate.com/github/thepracticaldev/dev.to/issues

You can sort by JavaScript and Ruby and other filters.

@benhalpern benhalpern added good first issue good first issues for anyone new to programming and new to the project. wsc2019 type: refactoring code refactors external contributors welcome contribution is welcome! labels Aug 18, 2019
@AnkitaSinghal
Copy link

AnkitaSinghal commented Aug 19, 2019

I would like to work on this issue. :)

@jessleenyc
Copy link
Contributor

Awesome. Just a note here that this is an evergreen issue -- there will (almost certainly) always be CodeClimate issues up for grabs so anyone should feel free to submit a PR here!

@feruzoripov
Copy link
Contributor

Hi, I've just made my first PR. But I got Travis CI failure. I can't figure out the reason. Can someone review my code, #3787 . Thanks )

@feruzoripov
Copy link
Contributor

Here another one #3793

@Aswathprabhu
Copy link
Contributor

Hi I've made my first PR, Can anyone review it?

@Aswathprabhu
Copy link
Contributor

Aswathprabhu commented Sep 30, 2019

Hi I've made some PRs (4154)(4156)(4157)(4161)(4159) I don't know why for some of them, Travis CI fails. I can't figure it out, Can anyone check on them?

@nickytonline
Copy link
Contributor

nickytonline commented Oct 9, 2019

There are issues in regards to OrgSettings.jsx in Code Climate, https://codeclimate.com/github/thepracticaldev/dev.to/app/javascript/listings/elements/orgSettings.jsx/source#issue-dd0645f9004d377c9bf71ba00f2b280a. I've started work on this. This is not the same work being done in #2470 in regards to eslint issues that @ruffle1986 is addressing.

@JulianoGTZ
Copy link
Contributor

Hi Folks. I have some doubts about this issue:

I'm trying to fix the code climate issues about the listing.jsx file and I have some doubts:

  • Has another issue with a refactoring example on the front-end side?
  • Has some tip about I can separate the parts on render in other components?
  • It's possible the usage of React hooks?

Thanks for the help.

@nickytonline
Copy link
Contributor

Hi Folks. I have some doubts about this issue:

I'm trying to fix the code climate issues about the listing.jsx file and I have some doubts:

  • Has another issue with a refactoring example on the front-end side?
  • Has some tip about I can separate the parts on render in other components?
  • It's possible the usage of React hooks?

Thanks for the help.

I gave some assistance for this in #6992

@JulianoGTZ
Copy link
Contributor

Hi folks. I tried to solve some codeclimate issues on listings/listings.jsx but I failed 😭.

Anyway, I did this pull-request which improves the legibility cleaning the render function.

@rhymes rhymes removed the future label Jul 1, 2020
@wyhaines
Copy link
Contributor

Just FYI -- the original link in the issue (https://codeclimate.com/github/thepracticaldev/dev.to/issues) does not exist anymore.

@nickytonline
Copy link
Contributor

I'm going to go ahead and close this as that project no longer exists in Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external contributors welcome contribution is welcome! good first issue good first issues for anyone new to programming and new to the project. type: refactoring code refactors
Projects
None yet
Development

No branches or pull requests