Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding dev.to comment in Dev.to results in broken HTML #4079

Closed
shushugah opened this issue Sep 22, 2019 · 4 comments
Closed

Embedding dev.to comment in Dev.to results in broken HTML #4079

shushugah opened this issue Sep 22, 2019 · 4 comments
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug smash Approved bugs for the DEV community bug smash bug always open for contribution external contributors welcome contribution is welcome!

Comments

@shushugah
Copy link

Describe the bug

On my post a regular dev.to comment was posted (albeit with Japanese characters in their profile) but when I embed their comment in my profile it shows broken HTML 4 tags

post (broken): https://dev.to/shushugah/gitlab-hacks-28cg
comment (not broken: https://dev.to/lukeshiru/comment/e7dd

Screenshots

Screenshot 2019-09-22 at 17 54 52

@jessleenyc jessleenyc added the bug always open for contribution label Sep 23, 2019
@jessleenyc jessleenyc added area: publishing experience issues related to an authors experience publishing. Tags, series, etc. triage labels Sep 23, 2019
@codenamev
Copy link

Working on this 😄

@rhymes rhymes removed the future label Jul 1, 2020
@rhymes rhymes removed the external contributors welcome contribution is welcome! label Oct 1, 2020
@rhymes rhymes added external contributors welcome contribution is welcome! and removed hacktoberfest labels Nov 5, 2020
@cmgorton cmgorton added the bug smash Approved bugs for the DEV community bug smash label May 5, 2021
@Eli-Schei
Copy link

I think this might be solved?

I tried to re-create the bug, but all comments are displayed nicely. Even the one from the original bug here.
When I inspect the html in the original post - with the broken comment - the html structure is completely different from how it is when I add a comment in a new post today.
Image of how it looks when I try to embed the comment today.
thinkItsFixed

@cmgorton
Copy link
Contributor

cmgorton commented May 6, 2021

I think this might be solved?

I tried to re-create the bug, but all comments are displayed nicely. Even the one from the original bug here.
When I inspect the html in the original post - with the broken comment - the html structure is completely different from how it is when I add a comment in a new post today.

Great! Figuring out that it is no longer a bug totally still counts! If you want to write up what you did in the template mentioned in the Bug Smash Post we will definitely still reward you for closing this bug. https://dev.to/new/devbugsmash 🐛 Thank you for helping us clean up the repo.
High five

@cmgorton cmgorton closed this as completed May 6, 2021
@shushugah
Copy link
Author

Thank you! I edited my post by adding a white space, to trigger/force a new render operation and it works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug smash Approved bugs for the DEV community bug smash bug always open for contribution external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

6 participants