Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runkit - indentation in the first line of a block #4948

Open
iksemot opened this issue Nov 26, 2019 · 9 comments
Open

Runkit - indentation in the first line of a block #4948

iksemot opened this issue Nov 26, 2019 · 9 comments
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug smash Approved bugs for the DEV community bug smash external contributors welcome contribution is welcome!

Comments

@iksemot
Copy link

iksemot commented Nov 26, 2019

Describe the bug

First line in the block of text cannot be indented.

To Reproduce

  1. Create a new post
  2. Add following content, make sure all lines are indented.
{% runkit %}
    console.log('BAD CODE')
    console.log('OK CODE')

    // BAD COMMENT
    // OK COMMENT
{% endrunkit %}
  1. Save the post

Expected behavior

All lines in RunKit embed should be indented.

Screenshots

image

Desktop (please complete the following information):

  • OS: Windows 10 Pro
  • Browser: Opera
  • Version: 65

Additional context

https://dev.to/tomaszrydzewski/runkit-indentation-2n9c-temp-slug-526549?preview=b14fe31c6205719176ea1eb56003f5a280d576a6c6e235a8587e6669eef1c45774687968a6bb6b677f09c7fc6a84289a59ceeb548b7d896fe1e94793

@jessleenyc jessleenyc added the area: publishing experience issues related to an authors experience publishing. Tags, series, etc. label Dec 2, 2019
@triage-new-issues triage-new-issues bot removed the triage label Dec 2, 2019
@triage-new-issues triage-new-issues bot removed the triage label Dec 2, 2019
@rhymes rhymes removed the future label Jul 1, 2020
@cmgorton cmgorton added the bug smash Approved bugs for the DEV community bug smash label May 4, 2021
@Om-Bhagwat
Copy link

I'll Like to take this one.

@cmgorton
Copy link
Contributor

cmgorton commented May 6, 2021

Awesome @Om-Bhagwat. I am assigning it to you now. If you have any questions as you start working on it feel free to reach out here.

@cmgorton
Copy link
Contributor

Hey @Om-Bhagwat wanted to check in and see how you are doing with this issue. Did you have any questions or need any help?

@SiddharthShyniben
Copy link
Contributor

I got a completely different output for the same code:

Screen Shot 2021-08-11 at 8 46 59 AM

Looks like the runkit liquid tags need a lot of work. (See #9743)

@cmgorton
Copy link
Contributor

Thanks for testing this @siddshy

@SiddharthShyniben
Copy link
Contributor

Can I take this?

@cmgorton
Copy link
Contributor

Yep. Just assigned you to it. Thanks!

@SiddharthShyniben
Copy link
Contributor

I'm having some trouble with the Forem Dev server. It never starts. Could somebody help me?

I'm using Gitpod, and I get awaiting port 3000... forever.

@Om-Bhagwat
Copy link

Om-Bhagwat commented Aug 25, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. bug smash Approved bugs for the DEV community bug smash external contributors welcome contribution is welcome!
Projects
None yet
Development

No branches or pull requests

6 participants