Error when submitting a comment on a recently deleted post

[adamkdean]

Describe the bug

Followed a link from an email, attempted to respond to a comment, received error There was an error in your markdown: undefined method id' for nil:NilClass`, comment not posted.

To Reproduce

Follow link from an email, attempt to respond to a comment.

Expected behavior

Comment is posted.

Screenshots

Desktop (please complete the following information):

• OS: MacOS 10.15.3
• Browser: Chrome 80.0.3987.87

[adamkdean]

Looks like the author deleted his post. Perhaps the solution here is better messaging to explain that the post/comment thread no longer exists.

[rhymes]

Thanks for the issue! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @thepracticaldev/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

[rhymes]

Hi @adamkdean, thanks for the issue! I edited the title to add context :)

[saroj990]

Hi @cmgorton, I would like to work on this issue.

[rhymes]

@saroj990 I've assigned this to you, thank you 🙌

[cmgorton]

Thanks @saroj990 . If you have any questions feel free to ask here or in your PR once opened. We are here to help along the way.

[saroj990]

What message do we need to display in the alert box for this issue ?

[cmgorton]

Good question. You could add some text for now that indicates the author deleted their comment. Once you have a PR in your reviewers may suggest something else. They will be able to respond more quickly in the PR itself with suggestions 😄

[saroj990]

@cmgorton created a PR for this issue.

[cmgorton]

Hey @saroj990 wanted to check in and see how you are doing with this issue. Did you have any questions or need any help? How are things going with your PR?

[saroj990]

Updated the PR with the required changes.