Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid comment in notifications list bad #7351

Closed
qm3ster opened this issue Apr 17, 2020 · 5 comments
Closed

Liquid comment in notifications list bad #7351

qm3ster opened this issue Apr 17, 2020 · 5 comments
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. bug always open for contribution good first issue good first issues for anyone new to programming and new to the project.

Comments

@qm3ster
Copy link

qm3ster commented Apr 17, 2020

Describe the bug

Annotation 2020-04-17 031307

To Reproduce

  1. Have a notification that shows a comment, for example a reply notification, wherein the text contains a liquid tag for another comment on dev.to
  2. Have a viewport width of over 1120px, so that #articles-list is no longer full-width, but fixed width instead.
  3. At viewport widths of 760px and over, .liquid-comment becomes width: 620px which kills the crab.
  4. Removing that fixes notifications view but breaks the normal views.

Expected behavior

Annotation 2020-04-17 031526

Desktop (please complete the following information):

  • OS: Classified
  • Browser: Chromium
  • Version: Classified

How to actually fix

Use flexbox for everything. Even post body. Especially post body.

@qm3ster
Copy link
Author

qm3ster commented Apr 17, 2020

I swear I saw a similar issue, but I can't find it in search again :(
If anyone knows how to find it, please link this there.

@citizen428 citizen428 added area: ui bug always open for contribution labels Apr 17, 2020
@citizen428
Copy link
Contributor

Thanks for the issue @qm3ster! We'll take your request into consideration and follow up if we decide to tackle this issue.

To our amazing contributors: issues labeled type: bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @thepracticaldev/oss and we will follow up within 3 business days.

For full info on how to contribute, please check out our contributors guide.

@rhymes
Copy link
Contributor

rhymes commented Apr 17, 2020

There might be some helpful clues in this other issue #7170

@qm3ster
Copy link
Author

qm3ster commented Apr 17, 2020

The issue I believe I saw had the words "liquid" "comment" and "overflow" in the title, but I can't find anything with those words or their permutations. I am shooketh.

@rhymes rhymes added area: design Use for all tasks related to UX, UI, visual, or interaction design. and removed area: ui labels May 14, 2020
@jacobherrington jacobherrington added the good first issue good first issues for anyone new to programming and new to the project. label May 26, 2020
@ludwiczakpawel
Copy link
Contributor

I think this should be now resolved (or at least outdated since we have updated Notifications center).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: design Use for all tasks related to UX, UI, visual, or interaction design. bug always open for contribution good first issue good first issues for anyone new to programming and new to the project.
Projects
None yet
Development

No branches or pull requests

5 participants