Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeahead liquid tag dropdown in new editor #872

Closed
benhalpern opened this issue Oct 9, 2018 · 6 comments
Closed

Typeahead liquid tag dropdown in new editor #872

benhalpern opened this issue Oct 9, 2018 · 6 comments
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. external contributors welcome contribution is welcome!

Comments

@benhalpern
Copy link
Contributor

benhalpern commented Oct 9, 2018

Is your feature request related to a problem? Please describe.
As a user, it can be hard to remember what exactly the commands for liquid tags in the editor are. In the way I might use this feature in my code, I'd like to type {% and get a list of options for autocomplete.

Additional context
The editor is built in Preact, and ideally this could be done without new dependencies, but if we need to use preact-compat, we could.

I believe the editor will need to be written as a content-editable div, and we'd listen for the typing etc.

Ultimately it should work similarly to how I use typeahead in VSCode etc. 🙂

This is what it might look like:

@bigblind
Copy link
Contributor

bigblind commented Oct 9, 2018

Would there be an endpoint where the client can ask the server for a list of liquid tags, or would the list on the front end be updated manually whenever a new tag is added?

@benhalpern
Copy link
Contributor Author

@bigblind For the purpose of the dropdown we'd probably ship it from the server with the page since there are only about a dozen.

So something like <div data-liquidtags="[github,glitch,link,etc]"></div>

And then we'd JSON.parse it to start playing with it.

@theoutlander
Copy link
Contributor

This is cool. I had made a similar request on the comment box thread (#354). I could tackle this one after the @ mention auto-suggest feature.

In addition, these features will need to be ported over to the editor. Ideally, we should be able to reuse what I'm building, but first we will need to turn it into a reusable library.

@stale
Copy link

stale bot commented Jan 19, 2019

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 7 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If this issue still requires attention, please respond with a comment. Happy Coding!

@stale stale bot added the stale label Jan 19, 2019
@rhymes
Copy link
Contributor

rhymes commented Jan 19, 2019

unstale

@stale stale bot removed the stale label Jan 19, 2019
@jessleenyc jessleenyc added the area: publishing experience issues related to an authors experience publishing. Tags, series, etc. label Mar 26, 2019
@cmgorton cmgorton added this to Backlog in Feature backlog via automation Nov 18, 2020
@cmgorton
Copy link
Contributor

Since this one has been around for a while without much traction I am going to close it and encourage anyone who would like to see this feature in the future to open a discussion in forem.dev . There we can get more eyes on potential features and highlight any we really would love the community to contribute too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: publishing experience issues related to an authors experience publishing. Tags, series, etc. external contributors welcome contribution is welcome!
Projects
No open projects
Development

No branches or pull requests

7 participants