You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
In the call out to sign in using Twitter or Github, a screenreader user just hears "Twitter" or "Github" when tabbing through the document. This could be confusing, thinking the link will take the user to Twitter or Github.
Below is a GIF that shows what a screenreader user hears when tabbing to those links:
Describe the solution you'd like
A better experience would be for a screenreader user to hear "Sign in using Twitter" or "Sign in using GitHub".
Describe alternatives you've considered
A simple way to accomplish this while keeping that additional text visually hidden would be to wrap it in a span element use a special visually-hidden class:
<ahref="/users/auth/twitter?callback_url=https://dev.to/users/auth/twitter/callback" class="cta cta-button" data-no-instant=""><spanclass="visually-hidden">Sign in using</span> TWITTER
</a>
In the main articles page CTA for signing in via Twitter or Github, previously, screen readers say "Twitter" and "GitHub." I added an `aria-label` attribute so that screen readers will say "Sign in with Twitter" and "Sign in with GitHub." Tested on Windows 7, in Chrome, using Chrome Vox extension, and works well!
Is your feature request related to a problem? Please describe.
In the call out to sign in using Twitter or Github, a screenreader user just hears "Twitter" or "Github" when tabbing through the document. This could be confusing, thinking the link will take the user to Twitter or Github.
Below is a GIF that shows what a screenreader user hears when tabbing to those links:
Describe the solution you'd like
A better experience would be for a screenreader user to hear "Sign in using Twitter" or "Sign in using GitHub".
Describe alternatives you've considered
A simple way to accomplish this while keeping that additional text visually hidden would be to wrap it in a
spanelement use a specialvisually-hiddenclass:Doing the above, the experience for a screenreader user is better and more accurate:
The text was updated successfully, but these errors were encountered: