Connect: Highlight @ mentions to logged in user #10216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludwiczakpawel
approved these changes
Sep 9, 2020
narender2031
approved these changes
Sep 17, 2020
pr-triage
bot
added
PR: partially-approved
nickytonline
suggested changes
Sep 17, 2020
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
nickytonline
reviewed
Oct 6, 2020
| @@ -38,4 +39,22 @@ describe('<Message />', () => { | |||
|
|
|||
| expect(profileLink.parentElement).toHaveStyle({ color: msg.color }); | |||
| }); | |||
|
|
|||
| it('should highlight @mentions to the logged in user', () => { | |||
There was a problem hiding this comment.
nitpick (non-blocking): Change the wording a bit.
Suggested change
| it('should highlight @mentions to the logged in user', () => { | |
| it('should highlight @mentions for the logged on user', () => { |
nickytonline
approved these changes
Oct 8, 2020
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
* Wrap with <mark> tags if mentioning current user
* Add test for @mention highlight
* Match @{username} mention
* Remove default param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR distinguishes between mentions to the logged in user and mentions to other users by wrapping @-mentions to the logged in user with
<mark>.Based on my understanding, it's not possible to wrap
<mark>tags at the time the message's HTML is generated inmodels/message.rb. Because of this, we'll have to highlight the @-mentions on the client side.The implementation in this PR makes this feature quite obscure but it happens to be the implementation with the fewest lines of changed code, so I just rolled with it.
Related Tickets & Documents
#9472
QA Instructions, Screenshots, Recordings
<mark>Added tests?
Added to documentation?