Removing duplicate date formatting for listing expiry date in listing dashboard #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not fill in the category for listing. That is what shows up extra space in the above screenshot |
nickytonline
approved these changes
Sep 10, 2020
Comment on lines
41
to
42
| {' '} | ||
| | Expires on: <DateTime dateTime={expiryDate} /> |
There was a problem hiding this comment.
Suggested change
| {' '} | |
| | Expires on: <DateTime dateTime={expiryDate} /> | |
| {' | Expires on: '}<DateTime dateTime={expiryDate} /> |
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: unreviewed
nickytonline
approved these changes
Sep 10, 2020
pr-triage
bot
added
PR: partially-approved
vaidehijoshi
approved these changes
Sep 13, 2020
| @@ -1,5 +1,6 @@ | |||
| import PropTypes from 'prop-types'; | |||
| import { h } from 'preact'; | |||
| import { h, Fragment } from 'preact'; | |||
There was a problem hiding this comment.
Nice! I'm reacquainting myself with React (and learning more about Preact!) and I hadn't heard of Fragment components before! Pretty neat; thanks for teaching me about them by using them in your PR 😸
pr-triage
bot
added
PR: merged
|
Thanks @rhymes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
It removes duplicate date formatting code for listing expiry date in listing dashboard
QA Instructions, Screenshots, Recordings
Added tests?
Added to documentation?