Refactoring user_controller separating some classes to service #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnohenrique
requested review from
a team and
msarit
and removed request for
a team
citizen428
reviewed
Sep 22, 2020
rhymes
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
Love it! I think you've addressed all of the requested changes
Thanks @brunnohenrique
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: unreviewed
brunnohenrique
commented
Sep 28, 2020
| @@ -54,7 +54,7 @@ def remove_org_credits | |||
| end | |||
|
|
|||
| def organization | |||
| Organization.find(org_params[:organization_id]) | |||
| @organization ||= Organization.find(org_params[:organization_id]) | |||
There was a problem hiding this comment.
Just an improvement appointed by @jonatasrancan
Ty!
citizen428
approved these changes
Oct 5, 2020
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
…#10384) * Refactoring user_controller separating some classes to service * Replace service Credit::Manager and improve yours specs * improve method with memoize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Remove some methods at
controllers/admin/users_controllers.rbto solve a codeclimate issue: over than 20 methodsRelated Tickets & Documents
#3739
Added tests?
Added to documentation?