Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll to Anchor #10464

Merged
merged 3 commits into from Oct 7, 2020
Merged

Add scroll to Anchor #10464

merged 3 commits into from Oct 7, 2020

Conversation

Link2Twenty
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Anchors are not currently caught by the router

Related Tickets & Documents

closes #10234
Related to #10238

QA Instructions, Screenshots, Recordings

  • Go to this post
  • Click on case study link
  • See anchor be picked up

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Sep 28, 2020
maestromac
maestromac requested changes Oct 5, 2020
View reviewed changes
app/assets/javascripts/base.js.erb Outdated Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 5, 2020
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Oct 6, 2020
maestromac
maestromac approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works locally. LGTM!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 6, 2020
@maestromac maestromac requested a review from a team October 6, 2020 16:21
jacobherrington
jacobherrington approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working for me! 👍

@jacobherrington jacobherrington merged commit b37b633 into forem:master Oct 7, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 7, 2020
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
@Link2Twenty @boardfish
[deploy] Add scroll to Anchor (forem#10464)
a4b1b31 
* Add scroll to Anchor

* Fix code typos

* Move to template litterals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobherrington jacobherrington jacobherrington approved these changes

@maestromac maestromac maestromac approved these changes

@nickytonline nickytonline Awaiting requested review from nickytonline

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to post sections
3 participants
@Link2Twenty @jacobherrington @maestromac