Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated minimum requirements for local installation on Windows #10513

Merged
merged 2 commits into from Oct 1, 2020
Merged

Updated minimum requirements for local installation on Windows #10513

merged 2 commits into from Oct 1, 2020

Conversation

sabarish98
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Windows recently extended WSL 2 support for more versions/ builds. Updated the prerequisites to the exact versions given in Microsoft Docs.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

No need for QA

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@sabarish98 sabarish98 requested a review from a team October 1, 2020 15:01
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 1, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

rhymes
rhymes reviewed Oct 1, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sabarish98

could you link https://docs.microsoft.com/en-us/windows/wsl/install-win10#requirements and/or https://devblogs.microsoft.com/commandline/wsl-2-support-is-coming-to-windows-10-versions-1903-and-1909/ inside the markdown file that was updated? This way a user can find further info if they need to

@sabarish98
Copy link
Contributor Author

Thanks @sabarish98

could you link https://docs.microsoft.com/en-us/windows/wsl/install-win10#requirements and/or https://devblogs.microsoft.com/commandline/wsl-2-support-is-coming-to-windows-10-versions-1903-and-1909/ inside the markdown file that was updated? This way a user can find further info if they need to

Yes @rhymes, will definitely do that as well

rhymes
rhymes approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks @sabarish98!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 1, 2020
@rhymes rhymes requested a review from maestromac October 1, 2020 15:24
@benhalpern benhalpern merged commit e1b3844 into forem:master Oct 1, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@benhalpern benhalpern benhalpern approved these changes

@jacobherrington jacobherrington Awaiting requested review from jacobherrington

@maestromac maestromac Awaiting requested review from maestromac

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sabarish98 @CLAassistant @rhymes @benhalpern