Disable autoplay on native videos #10516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdocr
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
LGTM
Also here's how it looks to me locally in case other reviewers have trouble setting up videos locally: https://share.getcloudapp.com/6quPk0XA
pr-triage
bot
added
PR: partially-approved
vaidehijoshi
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Thanks for this, @reobin, this looks good! Let's try it out :)
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
I'm not sure it 100% closes #6067 because the issue refers to a user setting for video autoplay.
The general consensus, for the moment, was to simply disable autoplay.
The
autostartvalue was removed since it defaults to false, and theplay()onreadywas also removed.Related Tickets & Documents
#6067
QA Instructions, Screenshots, Recordings
Added tests?
Added to documentation?