Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code link style so it uses the default link color #10578

Merged
merged 1 commit into from Oct 5, 2020
Merged

Remove code link style so it uses the default link color #10578

merged 1 commit into from Oct 5, 2020

Conversation

Coteh
Copy link
Contributor

@Coteh Coteh commented Oct 4, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Currently, the link color for the code element within articles is very similar to the color for normal code elements, making it hard to distinguish what is a link and what isn't. My solution is to remove the style that defines code links, so that it falls back to default color for links.

Related Tickets & Documents

Fixes #9603

QA Instructions, Screenshots, Recordings

Screenshots (changes outlined in red box)

Before
Screen Shot 2020-10-04 at 2 46 33 PM

After
Screen Shot 2020-10-04 at 2 43 40 PM

Steps

Make an article with the following content:

<a href="https://www.php.net/manual/en/function.system.php"><code>system()</code></a>

<code>system()</code>

[`My Example`](https://example.com/)

First and third elements should have the blue link color (or whatever --link-brand-color var is set to)
The second element should be black color (assuming --color-body-color was not changed by the tester)

edit: Additional test case:

putting this in an article:

`My Example`

should still render default black color for code elements.

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 4, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ludwiczakpawel ludwiczakpawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 5, 2020
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Coteh!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 5, 2020
@rhymes
Copy link
Contributor

rhymes commented Oct 5, 2020

@Coteh please sign the above CLA so we can go ahead and merge your first contribution ;-) 🎉

@Coteh
Copy link
Contributor Author

Coteh commented Oct 5, 2020

@rhymes Whoops did not realize I had to sign. Just signed. 👍

@rhymes rhymes merged commit 4687707 into forem:master Oct 5, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 5, 2020
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra CSS style for <code><a href= links
4 participants