Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feedback_message.message is required on backend but not required on view #10612

Merged
merged 1 commit into from Oct 6, 2020
Merged

feedback_message.message is required on backend but not required on view #10612

merged 1 commit into from Oct 6, 2020

Conversation

eusonlito
Copy link
Contributor

@eusonlito eusonlito commented Oct 5, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

feedback_message.message is required on backend validation but not set as required on view

forem/spec/models/feedback_message_spec.rb

Line 19 in 0ca4e8b

it { is_expected.to validate_presence_of(:message) }

QA Instructions, Screenshots, Recordings

Screenshot from 2020-10-05 18-00-47

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 5, 2020
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 5, 2020
@rhymes
Copy link
Contributor

rhymes commented Oct 5, 2020

Thanks @eusonlito!

@rhymes rhymes requested review from a team and nickytonline and removed request for a team October 5, 2020 16:20
nickytonline
nickytonline approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thanks so much for thePR @eusonlito. 🔥

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 6, 2020
@nickytonline nickytonline merged commit 70bd93d into forem:master Oct 6, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 6, 2020
@eusonlito eusonlito deleted the patch-1 branch October 6, 2020 18:51
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
@eusonlito @boardfish
feedback_message.message is required on backend but not required on v…
eba8be7 
…iew (forem#10612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@nickytonline nickytonline nickytonline approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eusonlito @rhymes @nickytonline