Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing example code in storybook #10765

Merged
merged 2 commits into from Oct 14, 2020
Merged

Showing example code in storybook #10765

merged 2 commits into from Oct 14, 2020

Conversation

Rafi993
Copy link
Contributor

@Rafi993 Rafi993 commented Oct 10, 2020

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

It shows example code in storybook that user can copy

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

code_sample

  1. Run storybook
  2. Go the example click "story" tab to view the source

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@Rafi993 Rafi993 requested a review from a team October 10, 2020 11:49
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 10, 2020
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 10, 2020
@rhymes rhymes removed the request for review from a team October 12, 2020 07:05
Copy link
Contributor

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR @Rafi993! 🚀

{
name: '@storybook/addon-storysource',
loaderOptions: {
prettierConfig: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rafi993, as a follow up PR, we could pull out the prettier config from package.json and make it its own file (a JS configuration file) which could be imported here so that we do not need to maintain two prettier configurations. For more information on this, see the Configuration File documentation for Prettier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. I'll create a pr for that.

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 14, 2020
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 14, 2020
@nickytonline nickytonline merged commit 9514df9 into forem:master Oct 14, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Oct 14, 2020
@nickytonline
Copy link
Contributor

Thanks so much for the PR @Rafi993! 🔥

@Rafi993 Rafi993 mentioned this pull request Oct 14, 2020
11 tasks
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
Co-authored-by: Nick Taylor <nick@dev.to>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants