Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing globals with node env #10767

Merged
merged 1 commit into from Oct 14, 2020
Merged

Replacing globals with node env #10767

merged 1 commit into from Oct 14, 2020

Conversation

Rafi993
Copy link
Contributor

@Rafi993 Rafi993 commented Oct 10, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

It replaces eslint statement /* globals process module */ with /* eslint-env node */ and also fixes eslint errors in file missing it

Related Tickets & Documents

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@Rafi993 Rafi993 requested a review from a team as a code owner October 10, 2020 16:52
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 10, 2020
@rhymes rhymes requested review from nickytonline and removed request for a team October 12, 2020 08:42
nickytonline
nickytonline approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@nickytonline nickytonline left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and today I learnt about /* eslint-env node */ 🔥

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 13, 2020
@nickytonline nickytonline requested a review from a team October 14, 2020 10:43
maestromac
maestromac approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maestromac maestromac merged commit 0d2b4c5 into forem:master Oct 14, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 14, 2020
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
@Rafi993 @boardfish
Replace globals with node env (forem#10767)
64d51e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickytonline nickytonline nickytonline approved these changes

@maestromac maestromac maestromac approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rafi993 @nickytonline @maestromac