Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dropdown svg for dark themes - comment section #10769

Merged
merged 4 commits into from Oct 13, 2020
Merged

fix dropdown svg for dark themes - comment section #10769

merged 4 commits into from Oct 13, 2020

Conversation

jmau111
Copy link
Contributor

@jmau111 jmau111 commented Oct 11, 2020 •
edited

What type of PR is this? (check all applicable)

  • Bug Fix

Description

If I understand this PR #9177 correctly, this modification solves the problem. Currently, with dark themes, the dropdown button is hidden.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

before :

Screenshot 2020-10-11 at 15 44 13

after :

Screenshot 2020-10-11 at 17 02 39

Added tests?

no

Added to documentation?

no

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 11, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 11, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 12, 2020
@ludwiczakpawel ludwiczakpawel requested a review from a team October 12, 2020 10:11
rhymes
rhymes suggested changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's working correctly.

It's quite dark in the dark theme:

Screenshot_2020-10-12 Let Us Now Praise Famous Men Et quod

It's invisible in the ten X theme:

Screenshot_2020-10-12 Let Us Now Praise Famous Men Et quod(1)

It's almost invisible in the light theme:

Screenshot_2020-10-12 Let Us Now Praise Famous Men Et quod(2)

It's almost invisible in the pink theme

Screenshot_2020-10-12 Let Us Now Praise Famous Men Et quod(3)

Same for the default theme:

Screenshot_2020-10-12 Let Us Now Praise Famous Men Et quod(4)

Am I missing something?

cc @ludwiczakpawel

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 12, 2020
@jmau111
Copy link
Contributor Author

jmau111 commented Oct 12, 2020

@ludwiczakpawel @rhymes erf, there are more changes to add, probably a little bit sass too, it's not the same logic everywhere. I'll take care of it and I'll test all themes. Is it possible to log in on local ?

@rhymes
Copy link
Contributor

rhymes commented Oct 12, 2020

@jmau111 sure! You have to configure either GitHub, Twitter or Facebook: https://docs.dev.to/backend/auth-github/ - https://docs.dev.to/backend/auth-twitter/ - https://docs.dev.to/backend/auth-facebook/

GitHub is probably the easiest to setup locally

@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Oct 12, 2020
@jmau111
Copy link
Contributor Author

jmau111 commented Oct 13, 2020

@rhymes @ludwiczakpawel should be better now. I've added an existing css var used for link color in that specific section.

rhymes
rhymes approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great @jmau111! Thank you!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 13, 2020
@rhymes rhymes merged commit fc933b9 into forem:master Oct 13, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 13, 2020
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
@jmau111 @boardfish
[deploy] fix dropdown svg for dark themes - comment section (forem#10769
2d0d952 
)

* fix dropdown svg for dark themes - comment section

* missing classes on buttons

* delete class ghost

* test svg on all themes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludwiczakpawel ludwiczakpawel ludwiczakpawel approved these changes

@rhymes rhymes rhymes approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmau111 @CLAassistant @rhymes @ludwiczakpawel