New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overflow of indented code-blocks in lists #10782
Merged
rhymes
merged 2 commits into
forem:master
from
Amorpheuz:Amorpheuz/fix-list-indented-code-block-overflow-9988
Oct 12, 2020
Merged
Fix overflow of indented code-blocks in lists #10782
rhymes
merged 2 commits into
forem:master
from
Amorpheuz:Amorpheuz/fix-list-indented-code-block-overflow-9988
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add styling for .highlight to <pre> inside <li>
ludwiczakpawel
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny ask, but other than that it seems to be working fine.
Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
ludwiczakpawel
approved these changes
Oct 12, 2020
rhymes
approved these changes
Oct 12, 2020
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
* fix overflow in list indented code blocks - add styling for .highlight to <pre> inside <li> * add `div.highlight` styling to `li blockquote.highlight` Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com> Co-authored-by: ludwiczakpawel <ludwiczakpawel@gmail.com>
Amorpheuz
added a commit
to Amorpheuz/forem
that referenced
this pull request
Oct 27, 2020
- undos forem#10782 - wraps li codeblocks with `div.highlight` - wraps pre tags with `div.highlight` in articles - adds `.highlight` class to pre tags in artricles
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds styling for
.highlightto<pre>inside<li>. I checked out theRouge/redcarpetplugin file which indicates that the.highlightclass should be applied to all code-blocks by default since DEV is using the default version too. I felt it would be a simpler fix via the CSS Route instead of configuring a custom renderer, which might lead to more bugs.I did basic testing with the following article piece, to ensure that behavior for other elements didn't get switched:
Related Tickets & Documents
Fixes #9988
QA Instructions, Screenshots, Recordings
If there are any instances of
<pre>blocks existing inside an<li>are there, a check will be needed to verify their behavior don't get changed. Would also love some feedback on whether it is better to fix this via a custom Renderer or is the CSS fix good? I would love to resend another PR with the renderer fix, albeit after more research on the same if it is the better solution.Bug:
Fixed:
Added tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?