Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignored columns from User #10787

Merged
merged 1 commit into from Oct 12, 2020
Merged

Conversation

citizen428
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Cleanup

Description

This finishes the work from #10732 and #10750, removing the ignored_colums statement from the User model.

Related Tickets & Documents

n/a

QA Instructions, Screenshots, Recordings

Nothing

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 12, 2020
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 12, 2020
@rhymes rhymes requested review from a team and nickytonline and removed request for a team October 12, 2020 08:50
@benhalpern benhalpern merged commit c340621 into master Oct 12, 2020
@benhalpern benhalpern deleted the citizen428/clean-up-user branch October 12, 2020 14:04
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 12, 2020
boardfish pushed a commit to boardfish/forem that referenced this pull request Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants