Fix missing category in delete draft listing URL #10809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
reviewed
Oct 12, 2020
There was a problem hiding this comment.
Hi @akshayymahajan, great find! do you think you can add a test to make sure this doesn't regress in the future?
Controller specs are in https://github.com/forem/forem/blob/master/spec/requests/listings_spec.rb
thank you!
|
Thanks, @rhymes. I will add a test for that. |
|
Hey @rhymes, I have added the test. Can you have a look? |
rhymes
requested review from
a team and
citizen428
and removed request for
a team
rhymes
approved these changes
Oct 13, 2020
pr-triage
bot
added
PR: partially-approved
benhalpern
approved these changes
Oct 13, 2020
pr-triage
bot
added
PR: merged
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
* added category in DASHBOARD_JSON_OPTIONS in listing_controller.rb * added test to make sure that draft listings contain category
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The JSON for listings on the listing dashboard page is missing the category key which causes an
undefinedin the delete listing URL. This PR adds the category key in the JSON.Related Tickets & Documents
Fixes #10800
QA Instructions, Screenshots, Recordings
Before
After
Added tests?
Added to documentation?