New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce twitter_timeline liquid tag (#7605) #10825
Introduce twitter_timeline liquid tag (#7605) #10825
Conversation
cec3a43
to
6bc352b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rafaltrojanowski thanks for kickstarting this.
A few notes:
- I can't see it in Firefox 82, mostly because the browser's builtin content blocking blocks it:
The resource at “https://platform.twitter.com/widgets.js” was blocked because content blocking is enabled
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Privacy/Tracking_Protection
I tried to disable the "Enhance tracking protection" feature for the website, and it worked, but we have to be aware that Firefox users may never see the timeline and not know they aren't seeing it. Is there an option B to render the timeline?
- The timeline widget is too long, this is as long as the timeline on Twitter, we might need to add scrollbars otherwise the vertical size of the article can go on forever. An example:
|
Hey @rafaltrojanowski (cześć! 🇵🇱) It does seem like we need to limit the height of this liquid tag to avoid situations thatx @rhymes mentioned. I think the most sensible way to do it is to go with either Github liquid tag fadeout (source):Comments fadeout:It would be also good to wrap this entire block with |
|
Cześć @ludwiczakpawel I've added styling updates based on Github liquid tag, please have a look: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cheers, looking good from my perspective!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this out locally and it works great! Thanks so much for the pull request @rafaltrojanowski! 🚀
|
Hey @rhymes Unfortunately, I didn't have a chance to look into the problem on Firefox yet, maybe it could be tacked in a separate PR? |
1544f1d
to
eb2dd9b
Compare




What type of PR is this? (check all applicable)
Description
This PR introduces a new twitter_timeline liquid tag. See #7605
Related Tickets & Documents
Closes #7605
QA Instructions, Screenshots, Recordings
{% twitter_timeline https://twitter.com/FreyaHolmer/timelines/1215413954505297922 %}Added tests?
Added to documentation?