Extracting prettier config #10847
Merged
Extracting prettier config #10847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
suggested changes
Oct 14, 2020
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
nickytonline
suggested changes
Oct 14, 2020
.prettierrc
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
refactor (blocking): Storybook fails to build because the webpack common js loader is unable to parse this file. Adding a .json extension will fix the issue.
WARN Unable to close preview build!
ERR! /Users/nickytonline/dev/forem/.prettierrc:2
ERR! "singleQuote": true,
ERR! ^
ERR!
ERR! SyntaxError: Unexpected token ':'
ERR! at wrapSafe (internal/modules/cjs/loader.js:1053:16)
ERR! at Module._compile (internal/modules/cjs/loader.js:1101:27)
ERR! at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
ERR! at Module.load (internal/modules/cjs/loader.js:985:32)
ERR! at Function.Module._load (internal/modules/cjs/loader.js:878:14)
ERR! at Module.require (internal/modules/cjs/loader.js:1025:19)
ERR! at require (internal/modules/cjs/helpers.js:72:18)
ERR! at Object.<anonymous> (/Users/nickytonline/dev/forem/app/javascript/.storybook/main.js:5:24)
ERR! at Module._compile (internal/modules/cjs/loader.js:1137:30)
ERR! at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
ERR! at Module.load (internal/modules/cjs/loader.js:985:32)
ERR! at Function.Module._load (internal/modules/cjs/loader.js:878:14)
ERR! at Module.require (internal/modules/cjs/loader.js:1025:19)
ERR! at require (internal/modules/cjs/helpers.js:72:18)
ERR! at interopRequireDefault (/Users/nickytonline/dev/forem/node_modules/@storybook/core/dist/server/utils/server-require.js:66:16)
ERR! at serverRequire (/Users/nickytonline/dev/forem/node_modules/@storybook/core/dist/server/utils/server-require.js:103:10)
ERR! /Users/nickytonline/dev/forem/.prettierrc:2
ERR! "singleQuote": true,
ERR! ^
ERR!
ERR! SyntaxError: Unexpected token ':'
ERR! at wrapSafe (internal/modules/cjs/loader.js:1053:16)
ERR! at Module._compile (internal/modules/cjs/loader.js:1101:27)
ERR! at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
ERR! at Module.load (internal/modules/cjs/loader.js:985:32)
ERR! at Function.Module._load (internal/modules/cjs/loader.js:878:14)
ERR! at Module.require (internal/modules/cjs/loader.js:1025:19)
ERR! at require (internal/modules/cjs/helpers.js:72:18)
ERR! at Object.<anonymous> (/Users/nickytonline/dev/forem/app/javascript/.storybook/main.js:5:24)
ERR! at Module._compile (internal/modules/cjs/loader.js:1137:30)
ERR! at Object.Module._extensions..js (internal/modules/cjs/loader.js:1157:10)
ERR! at Module.load (internal/modules/cjs/loader.js:985:32)
ERR! at Function.Module._load (internal/modules/cjs/loader.js:878:14)
ERR! at Module.require (internal/modules/cjs/loader.js:1025:19)
ERR! at require (internal/modules/cjs/helpers.js:72:18)
ERR! at interopRequireDefault (/Users/nickytonline/dev/forem/node_modules/@storybook/core/dist/server/utils/server-require.js:66:16)
ERR! at serverRequire (/Users/nickytonline/dev/forem/node_modules/@storybook/core/dist/server/utils/server-require.js:103:10)There was a problem hiding this comment.
Sorry. I did not double check it. Let me fix it.
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
nickytonline
approved these changes
Oct 15, 2020
pr-triage
bot
added
PR: partially-approved
fdocr
approved these changes
Oct 15, 2020
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
Co-authored-by: Nick Taylor <nick@iamdeveloper.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Extracting prettier config in a common place to address comment #10765 (comment)
Related Tickets & Documents
N/A
QA Instructions, Screenshots, Recordings
Make changes and commit the file to check if prettier config works
Added tests?
Added to documentation?