Add rails dbconsole #10861
Merged
Add rails dbconsole #10861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| terminal. | ||
|
|
||
| > Note: dbconsole reads database information from config/database.yml which is | ||
| > always better since database configs might change in the future. |
There was a problem hiding this comment.
I like the spirit of explaining this, but can we move this down beneath the list of steps? I think the break from the steps is a bit confusing.
What do you think?
There was a problem hiding this comment.
Totally agreed with breaking the flow from an user perspective. The note stands there to explain why we want users to go to the first alternative, but it didn't strike me that as an user, I can read the note later as well. I'll update this in the next commit.
jacobherrington
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
I think this is an improvement! Thanks for making this PR @ShubhankarKG, we always appreciate improvements to the documentation. 📜 👍
pr-triage
bot
added
PR: partially-approved
benhalpern
approved these changes
Oct 16, 2020
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
* Add rails dbconsole * Transfer note at bottom of steps as in PR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds
rails dbconsoleto open up database terminal, and explains why it is a better alternative.Related Tickets & Documents
Fixes #10843
QA Instructions, Screenshots, Recordings
Added tests?
Added to documentation?