Adds a new admin setting for experience levels. #10870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used in the post management UI to determine the range of experience. These values fallback to the ones we currently see in DEV, Total Newbies and Senior Devs. There is also a removal of the word coding when talking about experience level, since the context for each forem instance should be implied when referencing experience.
|
|
AfroDevGirl
commented
Oct 15, 2020
| <button value="1" name="rating_vote[rating]" class="level-rating-button <%= "selected" if @rating_vote&.rating == 1.0 %>">1</button> | ||
| <button value="2" name="rating_vote[rating]" class="level-rating-button <%= "selected" if @rating_vote&.rating == 2.0 %>">2</button> | ||
| <button value="3" name="rating_vote[rating]" class="level-rating-button <%= "selected" if @rating_vote&.rating == 3.0 %>">3</button> | ||
| <button value="1" name="rating_vote[rating]" class="level-rating-button <%= "selected" if @rating_vote&.rating.to_d == 1.0.to_d %>">1</button> |
There was a problem hiding this comment.
I was getting a rubocop issue on these. I'm happy to revert this particular change if y'all would prefer that.
fdocr
reviewed
Oct 15, 2020
There was a problem hiding this comment.
Thanks for taking a stab at this @AfroDevGirl!
I'm leaving a small implementation comment inline, which in general looks great to me. From the product context though @benhalpern may have some context or any other notes (if any)
benhalpern
approved these changes
Oct 16, 2020
pr-triage
bot
added
PR: partially-approved
fdocr
suggested changes
Oct 16, 2020
There was a problem hiding this comment.
Awesome, thanks for including the requested changes @AfroDevGirl.
The PR ran into some conflicts probably due to some recent edits to that file by other commits. Would you mind fixing those in order to merge this? Thanks!
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
fdocr
reviewed
Oct 16, 2020
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
17 tasks
boardfish
pushed a commit
to boardfish/forem
that referenced
this pull request
Oct 17, 2020
* Adds a new admin setting for experience levels. This is used in the post management UI to determine the range of experience. These values fallback to the ones we currently see in DEV, Total Newbies and Senior Devs. There is also a removal of the word coding when talking about experience level, since the context for each forem instance should be implied when referencing experience. * Cleans up experience defaults * Fixes instance_of usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
These admin settings are used in the post management UI to determine the range of experience. These values fallback to the ones we currently see in DEV, "Total Newbies" and "Senior Devs". There is also a removal of the word coding when talking about experience level, since the context for each forem instance should be implied when referencing experience.
Related Tickets & Documents
Closes #10845
QA Instructions, Screenshots, Recordings
What is your approximate experience level (1-5)?UX Settings:
Admin Config:
Post Management:
Added tests?
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
Edit: We need to add the values we want to display in DEV's admin dashboard to keep "Senior Devs" instead of the newly included defaults.
[optional] What gif best describes this PR or how it makes you feel?