Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid CSS word wrap in video player duration #10889

Merged
merged 2 commits into from Oct 20, 2020

Conversation

tudorpavel
Copy link
Contributor

@tudorpavel tudorpavel commented Oct 17, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

These new CSS rules override the overflow-wrap: anywhere and word-break: break-word rules in .crayons-article__header and also the overflow-wrap: anywhere rule in .crayons-card, but only for the JW player part of the DOM.

Related Tickets & Documents

Closes #10799

QA Instructions, Screenshots, Recordings

Before:
forem_before

After:
forem_after

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 17, 2020
@Link2Twenty
Copy link
Contributor

Hey @tudorpavel in your description if you change

Bug reported in #10799.

to

closes #10799

It will auto close the issue when the PR is merged 😊

Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @tudorpavel! Tested locally and LGTM

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 19, 2020
@fdocr fdocr requested review from a team and ludwiczakpawel and removed request for a team October 19, 2020 22:44
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 20, 2020
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 20, 2020
@rhymes rhymes merged commit cb8cb9b into forem:master Oct 20, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Oct 20, 2020
@tudorpavel tudorpavel deleted the video-player-word-wrap branch October 20, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total time in video player wraps to next line
5 participants