Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aliases for mod_roundrobin_notifications + email_follower_notifications to user model #6892 #10892

Merged
merged 1 commit into from Oct 20, 2020
Merged

Add aliases for mod_roundrobin_notifications + email_follower_notifications to user model #6892 #10892

merged 1 commit into from Oct 20, 2020

Conversation

matisnape
Copy link
Contributor

@matisnape matisnape commented Oct 17, 2020 •
edited by rhymes

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

Closes #6892

QA Instructions, Screenshots, Recordings

n/a

Added tests?

  • no, because they aren't needed

Added to documentation?

  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 17, 2020
@matisnape
Copy link
Contributor Author

/spec/system/user/view_user_index_spec.rb:19 this spec is failing on master as well 🤔

@matisnape matisnape force-pushed the add-notification-aliases-for-user-#6892 branch from 0ce9805 to 17c3371 Compare October 17, 2020 19:51
rhymes
rhymes approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @matisnape

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 20, 2020
@benhalpern benhalpern merged commit 1ca6f56 into forem:master Oct 20, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@benhalpern benhalpern benhalpern approved these changes

@citizen428 citizen428 Awaiting requested review from citizen428

@vaidehijoshi vaidehijoshi Awaiting requested review from vaidehijoshi

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename mod_roundrobin_notifications + email_follower_notifications on user model
3 participants
@matisnape @rhymes @benhalpern