Refactoring EditorAction #10894
Merged
Refactoring EditorAction #10894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the code climate error might be a false positive. |
nickytonline
suggested changes
Oct 28, 2020
|
|
||
| const { moreConfigShowing } = this.state; | ||
| const toggleMoreConfig = useCallback( |
There was a problem hiding this comment.
refactor (blocking): useCallback seems overkill here. For context, see When to useMemo and useCallback.
| onConfigChange, | ||
| submitting, | ||
| } = this.props; | ||
| const v1 = version === 'v1'; |
There was a problem hiding this comment.
nitpick (non-blocking): consider naming these isVersion1 and isVersion2.
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
nickytonline
approved these changes
Oct 28, 2020
pr-triage
bot
added
PR: partially-approved
Thank you @nickytonline |
rhymes
approved these changes
Oct 29, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Refactoring editor actions
Related Tickets & Documents
closes #10947
QA Instructions, Screenshots, Recordings
Added tests?
Added to documentation?