Fix RSpec unit testing when using Docker dev setup

[tudorpavel]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

When using the Docker dev setup, Elasticsearch is available at elasticsearch:9200 instead of localhost:9200 so the VCR testing config was not ignoring the requests needed for RSpec setup when doing Search::Cluster.recreate_indexes in spec/rails_helper.rb. Also the WebMock setup allows localhost requests which should also include Elasticsearch requests.

This seems okay to me, but I'm not sure if there is a better solution. One issue I might have is that a detail related to the Docker dev setup is bleeding into common RSpec configs. What do you think, @citizen428?

Related Tickets & Documents

Closes #10579

QA Instructions, Screenshots, Recordings

With this change you can run unit tests when using the Docker dev setup, for example this spec was failing at Search::Cluster.recreate_indexes in spec/rails_helper.rb and is now passing.

bundle exec rspec spec/liquid_tags/vimeo_tag_spec.rb

Added tests?

• yes
• no, because they aren't needed
• no, because I need help

Added to documentation?

• docs.forem.com
• readme
• no documentation needed

[mstruve]

Thanks for the fix! Since this does indeed solve the ticket I will approve, but I made a suggestion for also checking Redis if you have the time.

Thanks for your contribution!

[mstruve]

We are in the process of setting up Docker for our CI and this is one of the things I also had to add so +1 for doing it here. I think you might also need to add redis here as well. Worth checking.

Also, I believe you only need the host, elasticsearch and not the port.

[tudorpavel]

Also, I believe you only need the host, elasticsearch and not the port.

True, I added the port to be more specific but in this case it shouldn't be an issue.

I think you might also need to add redis here as well. Worth checking.

It's possible I missed it because I get some other unrelated failures such as missing Chrome binary. However I ran the entire RSpec suite with my Docker dev setup and I didn't see a VCR or WebMock failure for Redis requests, so I'm not sure it's needed. At least not until someone explicitly makes some Redis requests from RSpec.

[maestromac]

LGTM!