Use matched substring in Spotify liquid tag to avoid trailing whitespace #10953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
PR: partially-approved
benhalpern
approved these changes
Oct 20, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The bug was caused by a trailing whitespace character in the embed URL. Using the matched substring from
MatchDataavoids any additional whitespace. Also updated the spec to use explicit values instead of duplicating the logic from the code.Related Tickets & Documents
Closes #10951
QA Instructions, Screenshots, Recordings
Adding a Spotify liquid tag to an Article will now result in a valid embed iframe, while before it would display the text "Bad Request".
For example:
Before:
After:
Added tests?
Added to documentation?