Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use keyboard shortcut hook in article form #11014

Merged
merged 7 commits into from Oct 22, 2020
Merged

refactor: Use keyboard shortcut hook in article form #11014

merged 7 commits into from Oct 22, 2020

Conversation

Link2Twenty
Copy link
Contributor

@Link2Twenty Link2Twenty commented Oct 22, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Now we have a helper for keyboard shortcuts we can move old shortcuts over to this new method

Related Tickets & Documents

#10878

QA Instructions, Screenshots, Recordings

Press ctrl/command + shift + p in the new post page
it should toggle the preview

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

Mad laughter

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 22, 2020
@reobin
Copy link
Contributor

reobin commented Oct 22, 2020

Much cleaner now 🌞

Are you planning on doing all of the ones mentioned in #10878 in this PR?

@Link2Twenty
Copy link
Contributor Author

I think there's just the modal closing left?
Feel free to take that one if you want it 🙂

@reobin
Copy link
Contributor

reobin commented Oct 22, 2020

You're right, I thought there were more. I'll take the last one 👍

@Link2Twenty Link2Twenty changed the title Move to new shortcut system refactor: Use keyboard shortcut hook in article form Oct 22, 2020
rhymes
rhymes approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, just a note: the instructions say ctrl alt p not ctrl shift p

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 22, 2020
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 22, 2020
@benhalpern benhalpern merged commit c629459 into forem:master Oct 22, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 22, 2020
@rhymes rhymes mentioned this pull request Nov 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reobin reobin reobin left review comments

@rhymes rhymes rhymes approved these changes

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Link2Twenty @reobin @rhymes @benhalpern