refactor: Use keyboard shortcut hook in listing modal #11017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
PR: partially-approved
benhalpern
approved these changes
Oct 22, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Use the new keyboard shortcut hook to listen for
Escapekeypress to close an open listing modalRelated Tickets & Documents
#10878
QA Instructions, Screenshots, Recordings
EscapeAdded tests?
I'd like to add tests for this, but the
<Listings />component does not currently have tests.It seems to need a lot of stuff in order to set it up (mocking, adding divs to the DOM, etc.).
Any help with that is appreciated.
Closing the modal is probably not the most crucial test to do in this component, but if making the set up opens the door to more tests, then it's a win.
Added to documentation?
What gif best describes this PR or how it makes you feel?