Replacing old button with crayon buttons to make it more visible #11080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rafi993
changed the title
ludwiczakpawel
suggested changes
Oct 26, 2020
app/views/admin/mods/index.html.erb
Outdated
| @@ -48,7 +48,7 @@ | |||
| <% if params[:state] == "potential" %> | |||
| <td> | |||
| <%= form_with model: [:admin, mod], url: admin_mod_path(mod.id), method: :patch, local: true do |f| %> | |||
| <%= f.submit "Make Trusted", class: "btn btn-light js-add-to-mod-channel" %> | |||
| <%= f.submit "Make Trusted", class: "crayons-btn js-add-to-mod-channel" %> | |||
There was a problem hiding this comment.
Suggested change
| <%= f.submit "Make Trusted", class: "crayons-btn js-add-to-mod-channel" %> | |
| <%= f.submit "Make Trusted", class: "crayons-btn crayons-btn--secondary js-add-to-mod-channel" %> |
I think this button shouldn't be "prmiary" one (purple) but secondary. Primary button should be "reserved" for the most important action on a page (or within certain area).
I do agree that the button you have fixed originally could be a bit more visible and I think crayons-btn--secondary will be a better replacement in this case.
There was a problem hiding this comment.
This is how it looks after the above change
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
pr-triage
bot
added
PR: partially-approved
rhymes
approved these changes
Oct 26, 2020
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Replaces old button with crayon button it also improves button visibility
Related Tickets & Documents
Closes #11081
QA Instructions, Screenshots, Recordings
Before
After
Added tests?
Added to documentation?