Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11048 - clarify how to add multiple tags to a post #11082

Merged
merged 1 commit into from Oct 26, 2020
Merged

#11048 - clarify how to add multiple tags to a post #11082

merged 1 commit into from Oct 26, 2020

Conversation

clottman
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
    I think? Updates user-facing text, but that documents how to use the product.

Description

Clarify that multiple tags should be comma-separated. Quickly resolves some user confusion (mine, probably others). Added to the help text in the sidebar, not the placeholder text, for greater accessibility. (Screenreader users don't see the placeholder; the placeholder disappears once you've started typing/have your first tag written and are wondering how to get the second one to work.)

Related Tickets & Documents

#11048

QA Instructions, Screenshots, Recordings

Make sure the text looks okay on the new post page; I don't know why it wouldn't, but also, I did not go through the full setup & run this locally.

Added tests?

  • yes
  • no, because they aren't needed
  • no, because I need help

Added to documentation?

  • docs.forem.com
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Muscular Spongebob rips his shirt open

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 26, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2020

CLA assistant check
All committers have signed the CLA.

@Link2Twenty
Copy link
Contributor

Looks good to me

image

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

thanks @clottman

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 26, 2020
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 26, 2020
@ludwiczakpawel ludwiczakpawel merged commit 64dce93 into forem:master Oct 26, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 26, 2020
@clottman clottman deleted the patch-1 branch October 26, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants