A11y: Add shortcut to bookmark an article #11116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reobin
changed the title
|
Looks like an unrelated failure if someone could run Travis again? |
rhymes
requested review from
nickytonline,
ludwiczakpawel and
jacobherrington
rhymes
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
It seems to be working @reobin!
Just a note, please remember to prefix your username to the name of PRs, see the contributing guide for details https://docs.forem.com/contributing/forem/ - thank you!
pr-triage
bot
added
PR: partially-approved
benhalpern
approved these changes
Oct 27, 2020
pr-triage
bot
added
PR: merged
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds a shortcut on
b(for now?) to save an article as long as the user is focused somewhere inside the article.Also adds a shortcut on the signup modal to close it on
Escapekeypress. It helps to keep the navigation mouseless after pressingb.This will be more useful once #10468 is merged, but it can live on its own.
Also,
bis to discuss here. Other options have been discussed such asctrl+s.Related Tickets & Documents
Closes #11018
QA Instructions, Screenshots, Recordings
bAdded tests?
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?