Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor articles_controller #11122

Merged
merged 1 commit into from Oct 27, 2020

Conversation

ikanyu
Copy link
Contributor

@ikanyu ikanyu commented Oct 27, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Refactor unless statement and remove unused variables from ArticlesController

Related Tickets & Documents

#3739

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.

Added tests?

  • Yes
  • No, and this is why: Refactoring ticket
  • I need help with writing tests

Added to documentation?

  • Docs.forem.com
  • README
  • No documentation needed

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

img

Refactor unless statement and remove unused variables from controller
@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Oct 27, 2020
@ikanyu ikanyu marked this pull request as ready for review October 27, 2020 15:45
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Oct 27, 2020
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ikanyu!

Comment on lines -40 to -41
@allowed_tags = FEED_ALLOWED_TAGS
@allowed_attributes = FEED_ALLOWED_ATTRIBUTES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 27, 2020
@rhymes rhymes requested review from a team and jacobherrington and removed request for a team October 27, 2020 17:13
@benhalpern benhalpern merged commit b0ee1c3 into forem:master Oct 27, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 27, 2020
@ikanyu ikanyu deleted the refactor-articles-controller branch October 28, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants