Extract dashboard posts sort options to a constant #11123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
PR: partially-approved
krzysiek1507
force-pushed
the
refactor/extract-dashboard-posts-sort-options
branch
from
39dadff
to
1e26330
Compare
pr-triage
bot
added
PR: unreviewed
|
I've rebased the branch because something was failing. |
rhymes
requested review from
a team and
nickytonline
and removed request for
a team
nickytonline
approved these changes
Oct 27, 2020
| ["Most Views", "views-desc"], | ||
| ["Most Reactions", "reactions-desc"], | ||
| ["Most Comments", "comments-desc"], | ||
| ].freeze |
There was a problem hiding this comment.
❄️ ☃️ ❄️ ☃️ ❄️ ☃️ ❄️ ☃️
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
krzysiek1507
deleted the
refactor/extract-dashboard-posts-sort-options
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Extract sort options to a constant to reduce the number of allocations.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.
Added tests?
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?