Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Reaction model #11138

Merged
merged 1 commit into from Oct 29, 2020
Merged

Refactor Reaction model #11138

merged 1 commit into from Oct 29, 2020

Conversation

ikanyu
Copy link
Contributor

@ikanyu ikanyu commented Oct 28, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Deleted unused methods that are not found/used across the repository in the Reaction model. Also fixed one issue on CodeClimate :)
https://codeclimate.com/github/forem/forem/pull/11138

Related Tickets & Documents

#3739

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.

Added tests?

  • Yes
  • No, and this is why: Refactoring task
  • I need help with writing tests

Added to documentation?

  • Docs.forem.com
  • README
  • No documentation needed

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@ikanyu
Refactor Reaction model
5d36dc5 
Deleted unused methods that are not found/used across the repository in the Reaction model
@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Oct 28, 2020
@ikanyu ikanyu marked this pull request as ready for review October 28, 2020 16:15
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Oct 28, 2020
rhymes
rhymes approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ikanyu, I think these are fine refactorings, but I'd like @mstruve to confirm we don't need these methods anymore

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 29, 2020
@rhymes rhymes requested a review from mstruve October 29, 2020 07:43
mstruve
mstruve approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@mstruve mstruve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU!!!!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 29, 2020
@mstruve
Copy link
Contributor

mstruve commented Oct 29, 2020

Closing and reopening to see if we can get the Travis build to fire.

@mstruve mstruve closed this Oct 29, 2020
@mstruve mstruve reopened this Oct 29, 2020
@rhymes rhymes merged commit e0e410e into forem:master Oct 29, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@mstruve mstruve mstruve approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikanyu @mstruve @rhymes