Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor UsersController #11143

Merged
merged 2 commits into from Oct 28, 2020
Merged

Refactor UsersController #11143

merged 2 commits into from Oct 28, 2020

Conversation

ikanyu
Copy link
Contributor

@ikanyu ikanyu commented Oct 28, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Removed unused method #less_than_one_day_old? and refactor a few lines of code inside UsersController

Related Tickets & Documents

#3739

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.

Added tests?

  • Yes
  • No, and this is why: Refactoring task
  • I need help with writing tests

Added to documentation?

  • Docs.forem.com
  • README
  • No documentation needed

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@ikanyu
Refactor UsersController
1bd691c 
Removed unused method #less_than_one_day_old? and refactor a few lines of code
@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Oct 28, 2020
@ikanyu ikanyu marked this pull request as ready for review October 28, 2020 18:11
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Oct 28, 2020
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 28, 2020
fdocr
fdocr approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@fdocr fdocr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @ikanyu

@fdocr fdocr merged commit 0067a21 into forem:master Oct 28, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

@fdocr fdocr fdocr approved these changes

@jacobherrington jacobherrington Awaiting requested review from jacobherrington

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikanyu @benhalpern @fdocr