Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend link in config-env.md #11152

Merged
merged 1 commit into from Oct 29, 2020
Merged

Fix backend link in config-env.md #11152

merged 1 commit into from Oct 29, 2020

Conversation

ikanyu
Copy link
Contributor

@ikanyu ikanyu commented Oct 29, 2020 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Backend guide link currently leads to a Github 404 page. This commit fix the issue and redirects to the correct backend guide link

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

image

Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.

Added tests?

  • Yes
  • No, and this is why: Documentation update task
  • I need help with writing tests

Added to documentation?

  • Docs.forem.com
  • README
  • No documentation needed

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

image

@ikanyu
Fix backend link
0d28a71 
Backend guide link currently leads to a Github 404 page. This commit fix the issue and redirects to the correct backend guide link
@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Oct 29, 2020
@ikanyu ikanyu changed the title Fix backend link Fix backend link in config-env.md Oct 29, 2020
@ikanyu ikanyu marked this pull request as ready for review October 29, 2020 07:31
@ikanyu ikanyu requested a review from a team October 29, 2020 07:31
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Oct 29, 2020
rhymes
rhymes approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ikanyu!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 29, 2020
@rhymes rhymes requested a review from a team October 29, 2020 07:44
jacobherrington
jacobherrington approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@jacobherrington jacobherrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this ❤️

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 29, 2020
@jacobherrington jacobherrington merged commit 5a617f7 into forem:master Oct 29, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes approved these changes

@jacobherrington jacobherrington jacobherrington approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ikanyu @rhymes @jacobherrington