New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed envied docs #11160
removed envied docs #11160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yihyang, great catch! could you do the same for windows.md and linux.md and docs/getting-started/config-env.md ? thank you!
|
Hi @rhymes I have updated linux.md and windows.md in 5ab01c0 the |
|
Thanks for the update @yihyang! I meant line 40 which points to envied :D https://github.com/forem/forem/blame/master/docs/getting-started/config-env.md#L40 |
|
No worries @rhymes ! I think I removed in https://github.com/forem/forem/pull/11160/files#diff-bf09359bfc0d17184b7af3a60fe146c0e6e06949126ea2f38551510f25b3da5fL40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, sorry I didn't notice @yihyang, LGTM!
What type of PR is this? (check all applicable)
Description
Since ENVied Gem has been replaced by "dotenv" gem in the recent PR: #9767, the documentation should be update too.
Related Tickets & Documents
Related PRs: #9767
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.
Added tests?
Added to documentation?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?