Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed envied docs #11160

Merged
merged 3 commits into from Oct 30, 2020
Merged

Conversation

yihyang
Copy link
Contributor

@yihyang yihyang commented Oct 29, 2020

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Since ENVied Gem has been replaced by "dotenv" gem in the recent PR: #9767, the documentation should be update too.

Related Tickets & Documents

Related PRs: #9767

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, as well
as any relevant images for UI changes.

Added tests?

  • Yes
  • No, and this is why: this is a documentation update
  • I need help with writing tests

Added to documentation?

  • Docs.forem.com
  • README
  • No documentation needed

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@yihyang yihyang requested a review from a team October 29, 2020 16:06
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 29, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yihyang, great catch! could you do the same for windows.md and linux.md and docs/getting-started/config-env.md ? thank you!

@yihyang
Copy link
Contributor Author

yihyang commented Oct 29, 2020

Hi @rhymes I have updated linux.md and windows.md in 5ab01c0

the docs/getting-started/config-env.md seems to be pointing to the correct path: https://github.com/forem/forem/blame/master/docs/getting-started/config-env.md#L39

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 29, 2020
@rhymes
Copy link
Contributor

rhymes commented Oct 30, 2020

Thanks for the update @yihyang! I meant line 40 which points to envied :D https://github.com/forem/forem/blame/master/docs/getting-started/config-env.md#L40

@yihyang
Copy link
Contributor Author

yihyang commented Oct 30, 2020

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, sorry I didn't notice @yihyang, LGTM!

@benhalpern benhalpern merged commit 24a4a42 into forem:master Oct 30, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants