Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Change static color to theme variable #11179

Merged
merged 1 commit into from Oct 30, 2020

Conversation

FreakLevel
Copy link
Contributor

@FreakLevel FreakLevel commented Oct 30, 2020

What type of PR is this? (check all applicable)

  • Bug Fix

Description

In the integrations page some colors are statics, so doesn't change with the theme, that's make some colors doesn't match with the theme and text color.

Related Tickets & Documents

Fixes #11052

QA Instructions, Screenshots, Recordings

Check if the integrations page show colors relationated with the theme with hover and at select a github project.

Screen Shot 2020-10-27 at 03 00 25

Screen Shot 2020-10-27 at 03 01 37

Screen Shot 2020-10-27 at 03 06 23

Screen Shot 2020-10-27 at 03 07 55

Screen Shot 2020-10-27 at 03 09 40

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 30, 2020
@CLAassistant
Copy link

CLAassistant commented Oct 30, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great @FreakLevel, thanks!

ps. don't forget to prefix your username to your branch the next time :-) See the contributing guide

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 30, 2020
@benhalpern benhalpern merged commit 28961a2 into forem:master Oct 30, 2020
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected repos in GitHub integration don't use dark theme color
4 participants