Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make analytics show on all posts and add other details #1118

Merged
merged 1 commit into from Nov 14, 2018
Merged

Make analytics show on all posts and add other details #1118

merged 1 commit into from Nov 14, 2018

Conversation

benhalpern
Copy link
Contributor

@benhalpern benhalpern commented Nov 14, 2018 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This feature puts some of the finishing touches on the new dashboard area

Addresses #1103

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Nov 14, 2018
Zhao-Andy
Zhao-Andy approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What happens if the article is part of an org and part of a series?

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Nov 14, 2018
@benhalpern benhalpern merged commit 2022d45 into master Nov 14, 2018
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Nov 14, 2018
@maestromac maestromac deleted the ben/additional-dashboard branch November 14, 2018 18:31
@benhalpern benhalpern mentioned this pull request Nov 14, 2018
Closed
@benhalpern
Copy link
Contributor Author

@Zhao-Andy

@Zhao-Andy Zhao-Andy restored the ben/additional-dashboard branch November 14, 2018 19:41
@Zhao-Andy Zhao-Andy deleted the ben/additional-dashboard branch November 14, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhao-Andy Zhao-Andy Zhao-Andy approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benhalpern @Zhao-Andy