Docker compose config for developing and running tests #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I don't have a strong opinion here. @maestromac feel free to merge this if you like. |
bibendi
reviewed
Nov 20, 2018
|
@maestromac could you please review? |
maestromac
approved these changes
Jan 17, 2019
pr-triage
bot
added
PR: reviewed-approved
maestromac
reviewed
Jan 17, 2019
|
|
||
| ENTRYPOINT ["bundle", "exec"] | ||
| ADD https://github.com/krallin/tini/releases/download/v0.18.0/tini /tini |
There was a problem hiding this comment.
Tini's documentation stated that
NOTE: If you are using Docker 1.13 or greater, Tini is included in Docker itself. This includes all versions of Docker CE. To enable Tini, just pass the --init flag to docker run.
Does that apply here?
This was referenced Mar 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Added a couple of features for running project with docker:
docker-compose run app bundle exec rspec-extracted special base service
appfor running tasksrails dband browsing databaseRelated Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?